Skip to content

Arm backend: Up tolerance for conv2d, upsample_bilinear2d, etc.#18494

Merged
Christoffer-JL merged 2 commits intopytorch:mainfrom
Christoffer-JL:cjoh_tolerance
Mar 27, 2026
Merged

Arm backend: Up tolerance for conv2d, upsample_bilinear2d, etc.#18494
Christoffer-JL merged 2 commits intopytorch:mainfrom
Christoffer-JL:cjoh_tolerance

Conversation

@Christoffer-JL
Copy link
Copy Markdown
Collaborator

@Christoffer-JL Christoffer-JL commented Mar 25, 2026

Increased the tolerance for:

  • conv2 on TOSA FP/VGF
  • ic3 on TOSA FP16
  • T5 on TOSA INT/VGF

Change-Id: I42e912a4b609f93adeb5a55a9a71e8121368fae8

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Increased the tolerance for:
- conv2 on TOSA FP/VGF
- ic3 on TOSA FP16
- T5 on TOSA INT/VGF

Signed-off-by: Christoffer J.L. <christoffer.johanssonlundqvist@arm.com>
Change-Id: I42e912a4b609f93adeb5a55a9a71e8121368fae8
@Christoffer-JL Christoffer-JL added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Mar 25, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 25, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18494

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit a878ca4 with merge base b6824d1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2026
@Christoffer-JL
Copy link
Copy Markdown
Collaborator Author

test-arm-backend-vkml error
FAILED backends/arm/test/ops/test_permute.py::test_permute_vgf_quant[rank_4_large]
is a known unrelated problem.

The rest of the tests are unrelated

@Christoffer-JL Christoffer-JL merged commit 6986d91 into pytorch:main Mar 27, 2026
412 of 420 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants